Define IDL instructions for the confidential transfer fee extension #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lorisleiva I have added all instructions in IDL and added one test file for the initialization of the transfer fee. You can review this part. For other instruction testing taking time to understand ZK involved for multiple instructions that does not have any references in code. Let me know if have any references to check. For example - |
|
Thank you! This extension is very complex so, for now, I'm happy with just the initialisation test. 👌 I'll be reviewing this in a sec. |
Thank you for all the support! @lorisleiva |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR manually updates the Codama IDL to support all instructions in the confidential transfer fee extension. This allows helpers to be generated for the new web3.js.
This pull request was created for https://app.gib.work/bounties/a487ebf9-3e05-4877-920d-23e7d37f351e in an attempt to solve a bounty #23 . Payment for the bounty is immediately sent to the contributor after merge.